Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bid immutable #1249

Merged
merged 3 commits into from
Apr 29, 2021
Merged

Make bid immutable #1249

merged 3 commits into from
Apr 29, 2021

Conversation

DGarbar
Copy link
Contributor

@DGarbar DGarbar commented Apr 26, 2021

Most valuable changes in BidResponseCreator and ExchangeService.

If you want to how Jackson + Lombok (Builder) works with @JsonUnwrapped composition see GammaBid changes

@DGarbar DGarbar requested review from schernysh and rpanchyk April 26, 2021 11:49
@rpanchyk rpanchyk merged commit c1d5fbb into master Apr 29, 2021
@rpanchyk rpanchyk deleted the make-bid-immutable branch April 29, 2021 09:17
nickluck9 pushed a commit that referenced this pull request Aug 9, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
nickluck9 pushed a commit that referenced this pull request Aug 10, 2021
SerhiiNahornyi pushed a commit that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants